Page 1 of 1
Email when updating extension
Posted: Fri Jul 20, 2007 11:43 am
by DullForge
I had this problem last time I made an update to my extension(TimeZoneClock). It will not take my email as it should. My email is
[email protected]. I was able to make my changes to the extension by adding a
mailto:[email protected].
Someone should check out extensions and see why it is not validating my email.
Thanks
Dave
Re: Email when updating extension
Posted: Sun Jul 22, 2007 7:44 am
by doctorj
I dont see any issues. I removed the mailto: as it as causing some emails issues. If you update it manually, does it give an error? If so, what the error?
Re: Email when updating extension
Posted: Sun Jul 22, 2007 12:57 pm
by DullForge
it says : Please Enter a valid e-mail address where users can contact the deveoloper of the extension.
Looks like there is a validation function that is checking the email noted below
Code: Select all
function submitbutton(pressbutton) {
var form = document.adminForm;
if (pressbutton == 'cancel') {
submitform( 'viewlink' );
return;
}
if (form.link_name.value == ""){
alert( "Please fill in the extension name before submitting." );
} else if (form.link_desc.value == ""){
alert( "Please fill in the description before submitting." );
} else if (form.website.value == ""){
alert( "Please enter the Homepage URL before submitting." );
} else if (!gebid('cmt_com').checked && !gebid('cmt_mod').checked && !gebid('cmt_plugin').checked && !gebid('cmt_lang').checked && !gebid('cmt_esp').checked && !gebid('cmt_tool').checked ){
alert( "Please select the type of extension before submitting." );
} else if (!gebid('compat_10').checked && !gebid('compat_15').checked ){
alert( "Please select the compatibility of the extensions before submitting." );
} else if ( form.cust_1.value == "" ){
alert( "Please select the license type before submitting." );
} else if ( form.cust_4.value == "" ){
alert( "Please enter the download URL before submitting." );
} else if ( form.cust_14.value == "" ){
alert( "Please enter the developer name." );
} else if ( form.email.value == "" || (form.email.value.indexOf(".") <= 2) || (form.email.value.indexOf("@") <= 0)){
alert( "Please enter a valid e-mail address where users can contact the developer of the extension." );
} else {
form.task.value=pressbutton;
form.submit();
}
}
form.email.value.indexOf(".") <= 2
should probably be
Code: Select all
function submitbutton(pressbutton) {
var reg = /^([A-Za-z0-9_\-\.])+\@([A-Za-z0-9_\-\.])+\.([A-Za-z]{2,4})$/; //added
var address = form.email.value; //added
var form = document.adminForm;
if (pressbutton == 'cancel') {
submitform( 'viewlink' );
return;
}
if (form.link_name.value == ""){
alert( "Please fill in the extension name before submitting." );
} else if (form.link_desc.value == ""){
alert( "Please fill in the description before submitting." );
} else if (form.website.value == ""){
alert( "Please enter the Homepage URL before submitting." );
} else if (!gebid('cmt_com').checked && !gebid('cmt_mod').checked && !gebid('cmt_plugin').checked && !gebid('cmt_lang').checked && !gebid('cmt_esp').checked && !gebid('cmt_tool').checked ){
alert( "Please select the type of extension before submitting." );
} else if (!gebid('compat_10').checked && !gebid('compat_15').checked ){
alert( "Please select the compatibility of the extensions before submitting." );
} else if ( form.cust_1.value == "" ){
alert( "Please select the license type before submitting." );
} else if ( form.cust_4.value == "" ){
alert( "Please enter the download URL before submitting." );
} else if ( form.cust_14.value == "" ){
alert( "Please enter the developer name." );
} else if ( if(reg.test(address) == false)){ //changed
alert( "Please enter a valid e-mail address where users can contact the developer of the extension." );
} else {
form.task.value=pressbutton;
form.submit();
}
}
Re: Email when updating extension
Posted: Sun Jul 22, 2007 4:47 pm
by doctorj
Thanks I see the issue. I will forward this on to the team.
Re: Email when updating extension
Posted: Tue Jul 24, 2007 1:21 am
by dknight
Hello Dave,
The issue has been fixed. Thanks for bringing this in to attention.